Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skybox rotation issue #16628

Open
DiSaber opened this issue Dec 3, 2024 · 4 comments · May be fixed by #17476
Open

Skybox rotation issue #16628

DiSaber opened this issue Dec 3, 2024 · 4 comments · May be fixed by #17476
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Investigation This issue requires detective work to figure out what's going wrong
Milestone

Comments

@DiSaber
Copy link

DiSaber commented Dec 3, 2024

Bevy version

0.15.0

[Optional] Relevant system information

2024-12-03T15:41:25.228651Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 11 Pro", kernel: "22631", cpu: "AMD Ryzen 9 7950X 16-Core Processor", core_count: "16", memory: "31.6 GiB" }
2024-12-03T15:41:25.290845Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon RX 7900 XTX", vendor: 4098, device: 29772, device_type: DiscreteGpu, driver: "AMD proprietary driver", driver_info: "24.8.1 (LLPC)", backend: Vulkan }

What you did

Set the Skybox rotation field to something other than Quat::IDENTITY. In my case I set it to Quat::from_rotation_y(-45.0_f32.to_radians()) to align my skybox's sun with the directional light.

What went wrong

The skybox is not rendering correctly (the video shows the behavior)

Additional information

Workaround: Rotate the skybox texture itself

Video: https://github.com/user-attachments/assets/c8e1ab6d-ebde-475c-8298-0ac7e81abd62

@DiSaber DiSaber added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 3, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen S-Needs-Investigation This issue requires detective work to figure out what's going wrong and removed S-Needs-Triage This issue needs to be labelled labels Dec 11, 2024
@JMS55 JMS55 added this to the 0.15.2 milestone Jan 4, 2025
@BenjaminBrienen BenjaminBrienen added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Jan 21, 2025
@hukasu
Copy link

hukasu commented Jan 21, 2025

Screencast_20250121_141650.webm

replicated on main (85eceb0) by changing the rotation of the skybox on skybox example

cargo run --example skybox
Skybox {
            image: skybox_handle.clone(),
            brightness: 1000.0,
            rotation: Quat::from_rotation_y(-45.0_f32.to_radians()),
}

@hukasu hukasu linked a pull request Jan 21, 2025 that will close this issue
@hukasu
Copy link

hukasu commented Jan 21, 2025

@DiSaber can you test 575d17f to see if it still has the issue?

@DiSaber
Copy link
Author

DiSaber commented Jan 21, 2025

I'll have some time to test #17476 in a few hours. I'll update when I've done that. Thank you

@DiSaber
Copy link
Author

DiSaber commented Jan 21, 2025

I tested the skybox example and it looks like the issue is fixed, I tested before the commit and after. I can't test it directly on my project since that branch is based off of main (bevy_rapier and a few other crates won't compile I think). I expect it'll be fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Investigation This issue requires detective work to figure out what's going wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants