Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the trait Ease for Isometry3d #17539

Open
TheGrungringMachine opened this issue Jan 26, 2025 · 2 comments · May be fixed by #17545
Open

Implement the trait Ease for Isometry3d #17539

TheGrungringMachine opened this issue Jan 26, 2025 · 2 comments · May be fixed by #17545
Labels
A-Animation Make things move and change over time A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@TheGrungringMachine
Copy link

What problem does this solve or what need does it fill?

Being able to do something like:

let isometry_curve = EasingCurve::new(
            Isometry3d::new(Vec3::ZERO, Quat::IDENTITY),
            Isometry3d::new(Vec3::ZERO, Quat::IDENTITY),
            EaseFunction::CubicInOut,
        )
let isometry = isometry_curve.sample(t).unwrap();

What solution would you like?

Making Isometry3d struct implement Ease. (Not sure what else is needed to make the above code work?)

What alternative(s) have you considered?

Creating a curve singularly for both Vec3 and Quat.

@TheGrungringMachine TheGrungringMachine added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jan 26, 2025
@alice-i-cecile alice-i-cecile added A-Animation Make things move and change over time A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Jan 26, 2025
@alice-i-cecile
Copy link
Member

We should do the same for Isometry2D.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! label Jan 26, 2025
@RobWalt
Copy link
Contributor

RobWalt commented Jan 26, 2025

Working on this now!

@RobWalt RobWalt linked a pull request Jan 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Animation Make things move and change over time A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants