Add PHAR file to GitHub releases (PHIVE support) #531
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #531 +/- ##
============================================
+ Coverage 58.14% 66.6% +8.45%
- Complexity 2033 2049 +16
============================================
Files 128 125 -3
Lines 5005 5024 +19
============================================
+ Hits 2910 3346 +436
+ Misses 2095 1678 -417
Continue to review full report at Codecov.
|
|
@bobthecow Can you merge this PR? |
|
@bobthecow Can you check this? |
.travis.yml
Outdated
| @@ -32,14 +32,17 @@ script: | |||
| after_success: | |||
| - bash <(curl -s https://codecov.io/bash) | |||
|
|
|||
| before_deploy: make dist -j 4 | |||
| before_deploy: make dist -j 4 && cp build/psysh/psysh dist/psysh.phar && cp build/psysh/psysh.asc dist/psysh.asc | |||
There was a problem hiding this comment.
this should be done as part of the dist make target rather than inside .travis.yml
There was a problem hiding this comment.
As files already exist in build/psysh/psysh and build/psysh/psysh.asc, this (copying) is actually not needed, as I can directly release them to GitHub Releases.
Update: It is needed because psysh needs to be named psysh.phar and physh.asc needs to be named physh.phar.asc. I will move that to Makefile.
There was a problem hiding this comment.
Why does it need to be named psysh.phar? I’d really rather not.
There was a problem hiding this comment.
Because PHIVE requires that.
Why you don't want this? In case of installation with PHIVE, .phar will be dropped so user when saving wouldn't notice it.
There was a problem hiding this comment.
For everyone who looks at the github release and doesn’t use phive. It means the most downloadable looking thing in the release is a .phar, which is bound to cause confusion. I’ve never loved this about phive. I feel like it forces suboptimal experiences for non-phive users, unless I want to maintain my own repo server.
There was a problem hiding this comment.
But is this actually a problem? Because your website already shows installation with wget and composer. And if users need compat versions, they will probably already know that.
However, if you don't want that, you can set up custom repository server. I think that you can just use GitHub Pages for this with some CI script that automatically updates them at the new release. If you think this would be better, I can try to create new PR for it.
|
Might be worth checking it can be changed under PHAR? Alternatively you
could ship both files: one for phive and the other .phar; a user will not
download all the assets so I don’t thinking’s this should be a problem
…On Sun 1 Dec 2019 at 21:19, Filip Š ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#531 (comment)>:
> @@ -32,14 +32,17 @@ script:
after_success:
- bash <(curl -s https://codecov.io/bash)
-before_deploy: make dist -j 4
+before_deploy: make dist -j 4 && cp build/psysh/psysh dist/psysh.phar && cp build/psysh/psysh.asc dist/psysh.asc
But is this actually a problem? Because your website already shows
installation with wget and composer. And if users need compat versions,
they will probably already know that.
However, if you don't want that, you can set up custom repository server
<https://phar.io/distribute-your-own.html>. I think that you can just use
GitHub Pages for this with some CI script that automatically updates them
at the new release. If you think this would be better, I can try to create
new PR for it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#531?email_source=notifications&email_token=ABHPVAL5MVMSPQIJESARKP3QWQL63A5CNFSM4F7WEWTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNPIA5A#discussion_r352369945>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHPVAMPTAGMHYJBFDEWSMLQWQL63ANCNFSM4F7WEWTA>
.
|
Add support for signed PHIVE installation. Fix #489.
It will not be available until new release, because PHAR will be added to it.
Also, @bobthecow must set up GPG keys and add them to keyservers so PHAR will be signed. Details how to do that are on PHIVE site (section prerequisites) and in this article (all about creating and encrypting keys and adding them to Travis CI environment vars).
Basically, encrypted public and private keys should be added to
.github/keys.ascin this repository, key ID should be added to Travis CI environment variableKEY_ID, decryption key should be added to environment variableDECRYPT_KEYand signing key should be added to environment variableSIGN_KEY.This will enable installation with:
After that, pull request to PHIVE should be added to make alias available.