-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHAR file to GitHub releases (PHIVE support) #531
Open
filips123
wants to merge
7
commits into
bobthecow:develop
Choose a base branch
from
filips123:phive
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
32c3bfe
Add PHAR file to GitHub releases
filips123 4383aff
Fix PHAR adding to GitHub releases
filips123 9b42eda
Merge branch 'develop' into phive
filips123 cb9bf34
Merge branch 'develop' into phive
filips123 8a6df1f
Add support for signed PHARs
filips123 3dcf614
Move file copy to Makefile
filips123 181aef1
Fix filename of ASC file
filips123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be done as part of the
dist
make target rather than inside.travis.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As files already exist in
build/psysh/psysh
andbuild/psysh/psysh.asc
, this (copying) is actually not needed, as I can directly release them to GitHub Releases.Update: It is needed because
psysh
needs to be namedpsysh.phar
andphysh.asc
needs to be namedphysh.phar.asc
. I will move that toMakefile
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need to be named psysh.phar? I’d really rather not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because PHIVE requires that.
Why you don't want this? In case of installation with PHIVE,
.phar
will be dropped so user when saving wouldn't notice it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For everyone who looks at the github release and doesn’t use phive. It means the most downloadable looking thing in the release is a
.phar
, which is bound to cause confusion. I’ve never loved this about phive. I feel like it forces suboptimal experiences for non-phive users, unless I want to maintain my own repo server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is this actually a problem? Because your website already shows installation with
wget
andcomposer
. And if users need compat versions, they will probably already know that.However, if you don't want that, you can set up custom repository server. I think that you can just use GitHub Pages for this with some CI script that automatically updates them at the new release. If you think this would be better, I can try to create new PR for it.