-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: App to functional component #662
Conversation
be1df92
to
18e670a
Compare
Tests are red. Also, if I had to be a pain in the ass I'd say you should have made a commit for the hook translate, one for the breakpoint etc. |
18e670a
to
9563b28
Compare
9563b28
to
4b40a16
Compare
Yes I know, as I said in the PR description
Hmmm hooks like those just add a |
4b40a16
to
44f770e
Compare
44f770e
to
4a2972a
Compare
It's just way easier to review commit by commit with one commit dedicated to one thing. |
Can be merged if ok, previous PR #661 was merged |
My mistake it's not in this PR :( I add it right now, so my apologies |
This PR is a part [2] of multiple PR about the new sort logic in the application. Tests will maybe failed and probably don't after merging previous PR and rebasing this one.
(*) the Query is still not using hooks. It is the very first refactor, the hook will comes in an other PR