-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript, Prettier, and other dev deps #1014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glanced over it and it seems fine to me
defunctzombie
approved these changes
Nov 15, 2023
jtbandes
added a commit
that referenced
this pull request
Nov 16, 2023
### Public-Facing Changes The recording demo on mcap.dev can now record H.264-encoded CompressedVideo, if supported by the browser. ### Description - Use VideoEncoder to encode h264 - Detection of browser support & workarounds for some Safari issues (related to WebKit/WebKit#15562) Depends on #1014 (for VideoEncoder type definitions)
jtbandes
added a commit
to foxglove/eslint-plugin
that referenced
this pull request
Nov 16, 2023
### Public-Facing Changes Relaxed peer dependency for eslint-config-prettier to allow v9 ### Description Relates to foxglove/mcap#1014
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes [BREAKING] The `@mcap/core` source code now uses [private properties](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_properties). Depending on what runtime and build system you use to consume this package, you may need to add plugins or change settings to handle the new syntax. Modern JS engines and bundlers should not require any changes. ### Description - Upgrade TypeScript, Prettier, `@foxglove/eslint-plugin` etc. and fix new lint errors. - Use `es2022` for typescript `target` & `module` settings
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes The recording demo on mcap.dev can now record H.264-encoded CompressedVideo, if supported by the browser. ### Description - Use VideoEncoder to encode h264 - Detection of browser support & workarounds for some Safari issues (related to WebKit/WebKit#15562) Depends on foxglove#1014 (for VideoEncoder type definitions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
[BREAKING] The
@mcap/core
source code now uses private properties. Depending on what runtime and build system you use to consume this package, you may need to add plugins or change settings to handle the new syntax. Modern JS engines and bundlers should not require any changes.Description
@foxglove/eslint-plugin
etc. and fix new lint errors.es2022
for typescripttarget
&module
settings