Add h264 recording support to mcap.dev demo #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
reviewed
Nov 15, 2023
snosenzo
reviewed
Nov 15, 2023
snosenzo
reviewed
Nov 15, 2023
defunctzombie
approved these changes
Nov 15, 2023
james-rms
reviewed
Nov 15, 2023
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes The recording demo on mcap.dev can now record H.264-encoded CompressedVideo, if supported by the browser. ### Description - Use VideoEncoder to encode h264 - Detection of browser support & workarounds for some Safari issues (related to WebKit/WebKit#15562) Depends on foxglove#1014 (for VideoEncoder type definitions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
The recording demo on mcap.dev can now record H.264-encoded CompressedVideo, if supported by the browser.
Description
Depends on #1014 (for VideoEncoder type definitions)