Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmuc-mesh-vpn-wireguard: only use gluon.mesh_vpn #99

Conversation

grische
Copy link
Contributor

@grische grische commented Mar 17, 2024

@maurerle as discussed:
Instead of having a custom wireguard.mesh_vpn.enabled toggle always enable wireguard mesh vpn when gluon.mesh_vpn.enabled is enabled.

Instead of having a custom wireguard.mesh_vpn.enabled toggle always enable
wireguard mesh vpn when gluon.mesh_vpn.enabled is enabled.
@grische grische requested a review from maurerle March 17, 2024 21:19
@maurerle
Copy link
Member

This PR is not needed.
the wireguard mesh_vpn enabled setting is set in the gluon provider directly:

function M.enable(val)
uci:set('wireguard', 'mesh_vpn', 'enabled', val)
uci:save('wireguard')
end

Just like it is done for the upstream package:

https://github.com/freifunk-gluon/gluon/blob/d4847b697c1fb9da44751d659072e77e4dae6967/package/gluon-mesh-vpn-wireguard/luasrc/usr/lib/lua/gluon/mesh-vpn/provider/wireguard.lua#L19

So no change of this is required

@maurerle maurerle closed this Mar 17, 2024
@grische grische deleted the feature/use-gluon-meshvpn-toggle branch March 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants