Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify min_val semantics for torch.symbolic_int op #3959

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Clarify min_val semantics for torch.symbolic_int op #3959

merged 2 commits into from
Jan 14, 2025

Conversation

sjain-stanford
Copy link
Member

Addresses #3938 .

@sjain-stanford
Copy link
Member Author

@kuhar @stellaraccident PTAL, happy to incorporate any revisions.

@sjain-stanford sjain-stanford linked an issue Jan 14, 2025 that may be closed by this pull request
Semantics of torch.symbolic_int min_value #3938
Closed
@sjain-stanford sjain-stanford enabled auto-merge (squash) January 14, 2025 20:39
kuhar
kuhar approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sjain-stanford sjain-stanford merged commit 09af3b6 into llvm:main Jan 14, 2025
3 checks passed
@sjain-stanford sjain-stanford deleted the sambhav/min_val_shape branch January 14, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantics of torch.symbolic_int min_value
3 participants
@sjain-stanford @stellaraccident @kuhar