Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify min_val semantics for torch.symbolic_int op #3959

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Clarify min_val semantics for torch.symbolic_int op #3959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d89ec1b
add docstring comment clarifying the 0/1 specialization problem
sjain-stanford Jan 14, 2025
1a64fe2
use markdown
sjain-stanford Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions include/torch-mlir/Dialect/Torch/IR/TorchOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,6 +1361,15 @@ def Torch_SymbolicIntOp : Torch_Op<"symbolic_int", [Pure]> {
%0 = torch.symbolic_int "s0" {min_val = 5, max_val = 10} : !torch.int
%1 = torch.symbolic_int "s1" {min_val = 2, max_val = 20} : !torch.int
```

In this case, we see that `s0` has the range [5, 10] and `s1` has the
range [2, 20]. When unspecified, the range constraints feeding in from
TorchDynamo default to [0, INT_MAX] (or [2, INT_MAX] in older PyTorch
releases). In either case, the interpretation (as specified by TorchDynamo)
is that the dynamic dimension is assumed to be not 0 or 1. This is not a
bug, and does not necessarily mean that the exported program will not work
for dimensions 0 or 1. For an in-depth discussion of this topic, see
`The 0/1 Specialization Problem <https://docs.google.com/document/d/16VPOa3d-Liikf48teAOmxLc92rgvJdfosIy-yoT38Io/edit?fbclid=IwAR3HNwmmexcitV0pbZm_x1a4ykdXZ9th_eJWK-3hBtVgKnrkmemz6Pm5jRQ#heading=h.ez923tomjvyk>`_.
kuhar marked this conversation as resolved.
Show resolved Hide resolved
}];
let arguments = (ins
StrAttr:$symbol_name,
Expand Down
Loading