Resolved the unwanted hover effect and the text colour remains constant #10120
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request focuses on enhancing the visual feedback for selected appointment slots in two components: Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/pages/PublicAppointments/Schedule.tsx (1)
334-342: Consider simplifying the nested ternary operators.While the changes correctly address the text color consistency, the deeply nested ternary operators could be simplified for better maintainability.
Consider extracting the color logic into a separate function:
-selectedSlot?.id === slot.id - ? "text-white" - : percentage >= 1 - ? "text-gray-400" - : percentage >= 0.8 - ? "text-red-600" - : percentage >= 0.6 - ? "text-yellow-600" - : "text-green-600" +getSlotTextColor(selectedSlot?.id === slot.id, percentage) +// Add this function above the component or in a utils file +function getSlotTextColor(isSelected: boolean, percentage: number): string { + if (isSelected) return "text-white"; + if (percentage >= 1) return "text-gray-400"; + if (percentage >= 0.8) return "text-red-600"; + if (percentage >= 0.6) return "text-yellow-600"; + return "text-green-600"; +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/pages/Appointments/components/AppointmentSlotPicker.tsx(1 hunks)src/pages/PublicAppointments/Schedule.tsx(1 hunks)
🔇 Additional comments (1)
src/pages/Appointments/components/AppointmentSlotPicker.tsx (1)
215-223: LGTM! The text color logic enhancement improves readability.The changes effectively address the text color consistency issue by:
- Setting white text for selected slots
- Maintaining the existing color-coding for availability status
- Using group-hover for consistent hover state
| selectedSlotId === slot.id | ||
| ? "text-white" | ||
| : percentage >= 1 | ||
| ? "text-gray-400" | ||
| : percentage >= 0.8 | ||
| ? "text-red-600" | ||
| : percentage >= 0.6 | ||
| ? "text-yellow-600" | ||
| : "text-green-600", | ||
| )} |
There was a problem hiding this comment.
let's simplify this logic.
|
@NikhilA8606 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
Here is the screenshot
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
Bug Fixes