-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Fix update-otel #37706
base: main
Are you sure you want to change the base?
[chore] Fix update-otel #37706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @dmitryax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't see the reason why was done the way was done.
However, make otelcontribcol/make oteltestbedcol will overwrite the updated go.mod unexpectedly before step 2.
This PR removes the unexpected make otelcontribcol/make oteltestbedcol commands.
Without this the go.mod is not available.
@bogdandrutu Can we fix the workflow first and then look into this issue? |
Without this I cannot run the |
Let me explain one more time: |
I made my point, can move forward if you think this is the right thing
@bogdandrutu Thanks! Updated the PR according to your feedback. cc @mx-psi @codeboten |
Description
This PR fixed
make update-otel
to updatebuilder-config.yaml
correctly. This is the workflow we updatebuilder-config.yaml
files:MULTIMOD
command to updatego.mod
updatehelper
function to updatebuilder-config.yaml
according to the updatedgo.mod
However,
make otelcontribcol/make oteltestbedcol
will overwrite the updatedgo.mod
unexpectedly before step 2.This PR removes the unexpected
make otelcontribcol/make oteltestbedcol
commands.cc @mx-psi
Link to tracking issue
n/a
Testing
n/a
Documentation
n/a