feat: Update Facebook SDK dependency to latest version 16.x and remove ParseFacebookUtilsTvOS #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UtilsTvOS since with Facebook SDK version 16.x support for FacebookTV has been dropped
Thanks for opening this pull request!
|
matteolongeri-ovolab
changed the title
|
Why don't we remove FacebookUtils in general? I don't think that the Parse SDK should restrict the developer in which Facebook SDK to use, and this has been a constant topic with the current implementation. |
Closed
3 tasks
4 tasks
3 tasks
|
Closing via #1779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
This pull request increases Facebook SDK dependency to the latest version 16.x, giving apps the possibility to use it (actually they are limited to 15.x version, due to Parse dependency).
In addition ParseFacebookUtilsTvOS has been removed, since with version 16.x Facebook SDK has dropped support for FacebookTV.
Closes: #1773
Closes: #1764
Approach
The Package.swift manifest has been edited and ParseFacebookUtilsTvOS directory has been removed.
TODOs before merging