Cluster state types #2311
Closed
Cluster state types #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
force-pushed
the
pr2311
branch
3 times, most recently
from
345539a to
61fe276
Compare
muhamadazmy
force-pushed
the
pr2311
branch
2 times, most recently
from
7f721f2 to
190361d
Compare
muhamadazmy
force-pushed
the
pr2311
branch
5 times, most recently
from
1f17889 to
7def569
Compare
muhamadazmy
force-pushed
the
pr2311
branch
3 times, most recently
from
46f4206 to
7837086
Compare
| #[serde_as] | ||
| #[derive(Debug, Clone, Eq, PartialEq, Serialize, Deserialize)] | ||
| pub struct NodeData { | ||
| pub timestamp: MillisSinceEpoch, |
There was a problem hiding this comment.
what does timestamp refer to here?
There was a problem hiding this comment.
That should be last_update_time. I will rename it
muhamadazmy
force-pushed
the
pr2311
branch
5 times, most recently
from
cb5630b to
b3973f4
Compare
Summary: derprecate old cluster state that included information about partition state. A new ClusterState object is introduced that only have livenss information
Summary: Types used by nodes to share cluster state
Comment on lines
19
to
34
| super::define_rpc! { | ||
| @request=GetNodeState, | ||
| @response=NodeStateResponse, | ||
| @request_target=TargetName::NodeGetNodeStateRequest, | ||
| @response_target=TargetName::NodeGetNodeStateResponse, | ||
| @request=GetPartitionsProcessorsState, | ||
| @response=PartitionsProcessorsStateResponse, | ||
| @request_target=TargetName::NodeGetPartitionsProcessorsStateRequest, | ||
| @response_target=TargetName::NodeGetPartitionsProcessorsStateResponse, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Copy, Default, Serialize, Deserialize)] | ||
| pub struct GetNodeState {} | ||
| pub struct GetPartitionsProcessorsState {} | ||
|
|
||
| #[serde_as] | ||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub struct NodeStateResponse { | ||
| pub struct PartitionsProcessorsStateResponse { | ||
| /// State of paritions processor per parition. Is set to None if this node is not a `Worker` node | ||
| #[serde_as(as = "Option<serde_with::Seq<(_, _)>>")] | ||
| pub partition_processor_state: Option<BTreeMap<PartitionId, PartitionProcessorStatus>>, |
There was a problem hiding this comment.
possibly we should rename the module to be src/net/worker.rs since this worker-specific messaging and not node-level anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster state types
Summary:
Types used by nodes to share cluster state
Stack created with Sapling. Best reviewed with ReviewStack.
ClusterStatetypes #2434