Deprecate ClusterState types
#2434
Closed
+350
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
Closed
muhamadazmy
force-pushed
the
pr2434
branch
2 times, most recently
from
de80d30 to
d896c99
Compare
muhamadazmy
force-pushed
the
pr2434
branch
3 times, most recently
from
729d7dd to
16764bb
Compare
muhamadazmy
changed the title
muhamadazmy
force-pushed
the
pr2434
branch
4 times, most recently
from
f8d3c6c to
1e57e8a
Compare
muhamadazmy
changed the title
ClusterState types
muhamadazmy
force-pushed
the
pr2434
branch
2 times, most recently
from
164b95a to
9a553d2
Compare
Comment on lines
13
to
19
| import "restate/common.proto"; | ||
| import "restate/cluster.proto"; | ||
| import "google/protobuf/empty.proto"; | ||
| import "google/protobuf/duration.proto"; | ||
| import "google/protobuf/timestamp.proto"; | ||
|
|
||
| package restate.deprecated_cluster; |
There was a problem hiding this comment.
I'm assuming that this file is a simple rename that github doesn't recognize as a rename, right?
There was a problem hiding this comment.
It's confused because we still have a file with the same old name (cluster.proto)
muhamadazmy
force-pushed
the
pr2434
branch
2 times, most recently
from
9ae265e to
fe0a9fe
Compare
This was referenced Dec 27, 2024
Closed
Summary: This commit moves cluster.proto to deprecated_cluster.proto mainly but it also does the following: - Extract cluster configuration types to their own file. - Extract partition processor types (Status, RunMode, etc...) to their own file.
Closed
|
Is this ready for review? I see that it needs rebasing. |
|
The changes Till made regarding "Provisioning" are closely intertwined with mine, making it impossible to resolve with a simple rebase. I'll need to start over from scratch, but that's okay—it’s mostly mechanical work. |
|
Sorry for causing you trouble with my changes. I wasn't aware of the dependency. |
|
@tillrohrmann it's totally fine. No worries :D at all. I will pick this up again after the meeting based on the priorities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
ClusterStatetypesSummary:
This commit moves cluster.proto to deprecated_cluster.proto mainly but it also does
the following:
Stack created with Sapling. Best reviewed with ReviewStack.
ClusterStatetypes #2434