Use the VersionedValue version in etcd metdata store
#2473
Merged
+327
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
force-pushed
the
pr2473
branch
3 times, most recently
from
a0305d4 to
62655a3
Compare
muhamadazmy
requested review from
AhmedSoliman
and removed request for
tillrohrmann
tillrohrmann
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks a lot for fixing our etcd integration @muhamadazmy! Using an explicit version field looks like an elegant solution. The implementation looks correct to me. I assume that you've tested it locally with etcd, right? +1 for merging.
Comment on lines
190
to
191
| let mut version_key = BytesMut::from_iter(key); | ||
| version_key.put(&b"::version"[..]); |
There was a problem hiding this comment.
Preallocating the BytesMut might save us an reallocation when adding the ::version suffix.
|
@tillrohrmann Thank you so much for your review ❤️. Yes, I tested it locally. I will merge after applying your comment 😊 |
Summary: Avoid etcd version misalignment with `VersionedValue` by storing the version separately in its own key Fixes restatedev#2204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
VersionedValueversion in etcd metdata storeSummary:
Avoid etcd version misalignment with
VersionedValueby storing theversion separately in its own key
Fixes #2204