Handle config file replacement by some editors #2474
Merged
+59
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
force-pushed
the
pr2474
branch
2 times, most recently
from
17359e3 to
c7327b0
Compare
AhmedSoliman
approved these changes
Jan 8, 2025
Summary: We are switching mainly to notify-debounce-full to fix an issue with detecting file changes. This also gave us better control over the file watch and allows us to handle config file replacement. Also Some editors replace the file on save like what vim does.
|
@AhmedSoliman Done! Thank you for your review! Also it probably gonna be a while before I remember to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle config file replacement by some editors
Summary:
We are switching mainly to notify-debounce-full to fix an issue
with detecting file changes. This also gave us better control over
the file watch and allows us to handle config file replacement.
Also Some editors replace the file on save like what vim does.