-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Play Button stateful and remove intent toggle #6833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but I'll defer to Erika/Beyang for the backport approval :)
vscode/webviews/chat/cells/messageCell/human/editor/toolbar/SubmitButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport this PR manually, you can either: Via the sg toolUse the sg backport -r vscode-v1.64.x -p 6833 Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-vscode-v1.64.x vscode-v1.64.x
# Navigate to the new working tree
cd .worktrees/backport-vscode-v1.64.x
# Create a new branch
git switch --create backport-6833-to-vscode-v1.64.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2edd2640026853acb0038300c60cb6b08fffc3a6
# Push it to GitHub
git push --set-upstream origin backport-6833-to-vscode-v1.64.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-vscode-v1.64.x If you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-6833-to-vscode-v1.64.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-vscode-v1.64.x
Once the pull request has been created, please ensure the following:
|
The backport to
To backport this PR manually, you can either: Via the sg toolUse the sg backport -r jb-v7.12.x -p 6833 Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-jb-v7.12.x jb-v7.12.x
# Navigate to the new working tree
cd .worktrees/backport-jb-v7.12.x
# Create a new branch
git switch --create backport-6833-to-jb-v7.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2edd2640026853acb0038300c60cb6b08fffc3a6
# Push it to GitHub
git push --set-upstream origin backport-6833-to-jb-v7.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-jb-v7.12.x If you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-6833-to-jb-v7.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-jb-v7.12.x
Once the pull request has been created, please ensure the following:
|
This PR: - Removes the intent toggle feature completely. - Changes the intent dropdown behavior to only select the intent and not execute it automatically. - Enables the submit button even when the chat is empty. - the intent options in the dropdown only selects the intent mode and doesn't execute it. - after selecting the intent, changing the input, doesn't reset the intent. - on submit the selected intent is used and the intent selection message is displayed accordingly. - loading a chat from history and editing the message, doesn't persist the intent mode previously manually selected. - selecting a prompt correctly executes it in chat & edit modes. - make sure the submit button isn't disabled when the input is empty.
This PR: - Removes the intent toggle feature completely. - Changes the intent dropdown behavior to only select the intent and not execute it automatically. - Enables the submit button even when the chat is empty. - the intent options in the dropdown only selects the intent mode and doesn't execute it. - after selecting the intent, changing the input, doesn't reset the intent. - on submit the selected intent is used and the intent selection message is displayed accordingly. - loading a chat from history and editing the message, doesn't persist the intent mode previously manually selected. - selecting a prompt correctly executes it in chat & edit modes. - make sure the submit button isn't disabled when the input is empty.
These changes are pre-approved by @beyang during Monday's team sync. Merging the backports to unblock. |
backport: #6833 This PR: - Removes the intent toggle feature completely. - Changes the intent dropdown behavior to only select the intent and not execute it automatically. - Enables the submit button even when the chat is empty. - the intent options in the dropdown only selects the intent mode and doesn't execute it. - after selecting the intent, changing the input, doesn't reset the intent. - on submit the selected intent is used and the intent selection message is displayed accordingly. - loading a chat from history and editing the message, doesn't persist the intent mode previously manually selected. - selecting a prompt correctly executes it in chat & edit modes. - make sure the submit button isn't disabled when the input is empty. ## Test plan <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. -->
backport: #6833 This PR: Removes the intent toggle feature completely. Changes the intent dropdown behavior to only select the intent and not execute it automatically. Enables the submit button even when the chat is empty. ## Test plan the intent options in the dropdown only selects the intent mode and doesn't execute it. after selecting the intent, changing the input, doesn't reset the intent. on submit the selected intent is used and the intent selection message is displayed accordingly. loading a chat from history and editing the message, doesn't persist the intent mode previously manually selected. selecting a prompt correctly executes it in chat & edit modes. make sure the submit button isn't disabled when the input is empty. <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. -->
This PR:
Test plan