-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pre-defined choices for company types #3702
base: master
Are you sure you want to change the base?
Use pre-defined choices for company types #3702
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3702 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 700 701 +1
Lines 22430 22434 +4
=======================================
+ Hits 20099 20103 +4
Misses 2331 2331 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can be used in filtering on /companies, and to auto-complete the interest form after a company has been selected (the company interest model already uses the same choices).
The text field is not optional in the frontend, so it has not been used that much. I will manually migrate these.