Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpimath] Add deprecation message to ElevatorFeedforward #7737

Conversation

calcmogul
Copy link
Member

C++ already has one.

Fixes #7736.

@calcmogul calcmogul requested a review from a team as a code owner January 27, 2025 03:30
@github-actions github-actions bot added the component: wpimath Math library label Jan 27, 2025
@sciencewhiz
Copy link
Contributor

There's several more places where there's one deprecated tag or the other but not both. Checkstyle has a check for that. I'm working on a PR to enable that check and fix all the cases.

sciencewhiz added a commit to Beachbot330/allwpilib that referenced this pull request Jan 27, 2025
Ensures java deprecated notation is paired with javadoc and vice versa.
Adds javadoc deprecation for MecanumControllerCommand, ArmFeedForward,
ElevatorFeedforward, and MecanumDriveMotorVoltages
Fixes wpilibsuite#7736
Supersedes wpilibsuite#7737
@calcmogul calcmogul closed this Jan 27, 2025
@calcmogul calcmogul deleted the wpimath-add-deprecation-message-to-elevator-feedforward branch January 27, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wpimath] ElevatorFeedforward calculate() deprecation is not documented
2 participants