Move all internal dependancies into the workspace. #17486
Conversation
alice-i-cecile
added
C-Code-Quality
| bevy_derive = { workspace = true, default-features = true } | ||
| bevy_log = { workspace = true, default-features = true } | ||
| bevy_math = { workspace = true, default-features = true } | ||
| bevy_reflect = { workspace = true, default-features = true, features = [ |
There was a problem hiding this comment.
Won't this enable these features for all of the crates that rely on bevy_reflect across the workspace? My understanding was that only a single version of the crate is selected.
There was a problem hiding this comment.
According to this, it seems like that is already the case for the current method:
When building multiple packages in a workspace (such as with --workspace or multiple -p flags), the features of the dependencies of all of those packages are unified. If you have a circumstance where you want to avoid that unification for different workspace members, you will need to build them via separate cargo invocations.
This post goes over some of the pitfalls of dependancy unification, but that appears to apply to workspaces in general, not just workspace level dependancies.
But I could totally be wrong here. It's kinda confusing.
There was a problem hiding this comment.
I think the main concern is when a project has a direct dependency on a crate like bevy_ecs, they shouldn't have extra features due to the workspace structure.
There was a problem hiding this comment.
I don't think that will be effected. Only members built at the same time should have their dependencies unified.
Just beware that if you build multiple workspace members at the same time, the features will be unified so that if one member sets default-features = true (which is the default if not explicitly set), the default-features will be enabled for all members using that dependency.
But upon rereading this, I think I was wrong about default-features being opt out when disabled on a workspace level.
I will see about fixing that tomorrow.
There was a problem hiding this comment.
I just tested running cargo tree -p bevy_ecs -e features and bevy_reflect has no features enabled, same as in main.
So if you compile an individual sub-crate, only its required features should be enabled.
BenjaminBrienen
added
the
D-Straightforward
|
blocked on dependabot/dependabot-core#7896 |
mockersf
added
the
S-Blocked
alice-i-cecile
removed
the
S-Needs-Review
This moves all internal crate dependancies into the root
Cargo.toml, which can be referenced usingworkspace = true.Fixes #16652.
Default features
Because of the way workspace dependancies work,
default-featuresare now opt-in (see this warning for details).